Repository navigation
GPUCommonDefAPI: add GPUhdii() - #15991
Merged
Merged
Conversation
Collaborator
Author
|
@davidrohr I am not sure if I should apply the clang-formatting suggested by CI seems wrong? |
Collaborator
|
I don't know why clang-format wants to change something, please just ignore it. For the new macro: If needed, this is of course fine. Though, in general, I'd like to rather remove variants instead of adding new ones. GPUhdii would be force-inline for host code that drives the GPU. Is there a real use case for this? |
Collaborator
Author
|
Yes, mostly it is for to force-inline a shared helper on both host and device. |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add variant to force inline on device and host.
Diff is actually just +5 lines but I manually indented the comments.